Re: [PATCH 1/1] Introduce "precious" file concept
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 22, 2019, 18:07 UTC
- Message-ID
- <xmqqk1hrr91s.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8CB=P9T0XJMWQetExgwDyFN78nuJZq8FtmzG+V1fBY4ig@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 20 quoted lines
> On Thu, Feb 21, 2019 at 5:39 AM Junio C Hamano <gitster@pobox.com> wrote: >> > So now you would need to >> > add more or less the same set of ignore rules in .gitattributes to >> > mark them trashable, and gitignore/gitattributes rules are not exactly >> > compatible, you can't just blindly copy them over. Every time you add >> > one more .gitignore rule, there's a good chance you need to add a >> > similar rule for trashable attribute. >> >> I am not sure why you would even need to _duplicate_. >> >> Are you saying for each and every rule that specify "ignored and >> expendable" in .gitignore there always will be "ignored but >> precious" exception that match the pattern? Given that we have been >> OK for so long without even needing "precious", I find it somewhat >> unrealistic to assume so. > > If all ignored files are now redefined as precious and we mark them > expendable with trashable attribute, then we need to duplicate most of > the rules. The "precious" attribute of course does not have this > problem since precious-and-ignored files should be rare.
Ah, so you are saying that ignored (the traditional one we always had) plus precious is a better combination than ignored (repurposed to mean ignored-but-precious) plus trashable, because the latter will cause people configure with a lot of duplication?
If that is the case, I'd agree ;-)