Re: [PATCH 1/1] Introduce "precious" file concept

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 22, 2019, 09:35 UTC
Message-ID: <CACsJy8CB=P9T0XJMWQetExgwDyFN78nuJZq8FtmzG+V1fBY4ig@mail.gmail.com>
In-Reply-To: <xmqqo976ultb.fsf@gitster-ct.c.googlers.com>

On Thu, Feb 21, 2019 at 5:39 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> > So now you would need to
> > add more or less the same set of ignore rules in .gitattributes to
> > mark them trashable, and gitignore/gitattributes rules are not exactly
> > compatible, you can't just blindly copy them over. Every time you add
> > one more .gitignore rule, there's a good chance you need to add a
> > similar rule for trashable attribute.
>
> I am not sure why you would even need to _duplicate_.
>
> Are you saying for each and every rule that specify "ignored and
> expendable" in .gitignore there always will be "ignored but
> precious" exception that match the pattern?  Given that we have been
> OK for so long without even needing "precious", I find it somewhat
> unrealistic to assume so.

If all ignored files are now redefined as precious and we mark them expendable with trashable attribute, then we need to duplicate most of the rules. The "precious" attribute of course does not have this problem since precious-and-ignored files should be rare.

-- 
Duy