Re: [PATCH v2 4/5] doc: be more precise on (fetch|push).recurseSubmodules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 3, 2020, 22:05 UTC
- Message-ID
- <xmqqo8td6qmm.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20200303170740.1879432-5-damien.olivier.robert+git@gmail.com>
Damien Robert <damien.olivier.robert@gmail.com> writes:
Show 16 quoted lines
> diff --git a/Documentation/config/fetch.txt b/Documentation/config/fetch.txt > index f11940280f..8f716809f9 100644 > --- a/Documentation/config/fetch.txt > +++ b/Documentation/config/fetch.txt > @@ -2,10 +2,12 @@ fetch.recurseSubmodules:: > This option can be either set to a boolean value or to 'on-demand'. > Setting it to a boolean changes the behavior of fetch and pull to > unconditionally recurse into submodules when set to true or to not > - recurse at all when set to false. When set to 'on-demand' (the default > - value), fetch and pull will only recurse into a populated submodule > + recurse at all when set to false. When set to 'on-demand', > + fetch and pull will only recurse into a populated submodule > when its superproject retrieves a commit that updates the submodule's > reference. > + If not set, it fallbacks to the value of `submodule.recurse`, and > + if both are not set the default value is 'on-demand'.
I do not think "fallback" is a single-word verb. If you must use the phrase, "it falls back to the value of ...", but I personally prefer to give the simplest case first and then its variants second (i.e. if you do not do anything, this is what you get, and then if you do this thing, this other thing happens).
In other words:
If not set, 'on-demand' is used by default, unless 'submodule.recurse' is set, in which case it is used.
But in this case it is so obvious that it would not be necessary to add ", in which case it is used" at the end.
Show 11 quoted lines
> diff --git a/Documentation/config/push.txt b/Documentation/config/push.txt > index 54871f8213..2a5250cf5c 100644 > --- a/Documentation/config/push.txt > +++ b/Documentation/config/push.txt > @@ -112,3 +112,6 @@ push.recurseSubmodules:: > is 'no' then default behavior of ignoring submodules when pushing > is retained. You may override this configuration at time of push by > specifying '--recurse-submodules=check|on-demand|no'. > + If not set, it fallbacks to the value of `submodule.recurse` (where > + a 'true' value means 'on-demand'), and if both are not set the > + default value is 'no'.
Likewise.
Show 11 quoted lines
> diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt > index a115a1ae0e..58972b1a05 100644 > --- a/Documentation/fetch-options.txt > +++ b/Documentation/fetch-options.txt > @@ -163,7 +163,8 @@ ifndef::git-pull[] > value. Use 'on-demand' to only recurse into a populated submodule > when the superproject retrieves a commit that updates the submodule's > reference to a commit that isn't already in the local submodule > - clone. > + clone. By default this uses the fetch.recurseSubmodules value (see > + linkgit:git-config), and the default value is 'on-demand'.
By default, 'on-demand' is used, unless `fetch.recurseSubmodules` is set (see linkgit:git-config[1]).