Re: [PATCH v3 4/5] doc: be more precise on (fetch|push).recurseSubmodules
- From
Philippe Blain <levraiphilippeblain@gmail.com>
- Date
- Mar 22, 2020, 22:37 UTC
- Message-ID
- <260F83FF-484B-438A-B70A-8348A5267877@gmail.com>
- In-Reply-To
- <20200320213729.571924-5-damien.olivier.robert+git@gmail.com>
Show 11 quoted lines
> Le 20 mars 2020 à 17:37, Damien Robert <damien.olivier.robert@gmail.com> a écrit : > > diff --git a/Documentation/config/fetch.txt b/Documentation/config/fetch.txt > index f11940280f..8778a99fa6 100644 > --- a/Documentation/config/fetch.txt > +++ b/Documentation/config/fetch.txt > @@ -1,11 +1,13 @@ > fetch.recurseSubmodules:: > - This option can be either set to a boolean value or to 'on-demand'. > + This option can be set either to a boolean value or to 'on-demand'. > Setting it to a boolean changes the behavior of fetch and pull to
I think in the context of patch 5 maybe it would be good to be careful here, and state that this only affects the underlying "fetch" in "pull", and not the whole pull ?
Show 10 quoted lines
> - unconditionally recurse into submodules when set to true or to not > - recurse at all when set to false. When set to 'on-demand' (the default > - value), fetch and pull will only recurse into a populated submodule > + recurse unconditionally into submodules when set to true or to not > + recurse at all when set to false. When set to 'on-demand', > + fetch and pull will only recurse into a populated submodule > when its superproject retrieves a commit that updates the submodule's > reference. > + If not set, 'on-demand' is used by default, unless > + 'submodule.recurse' is set.
I know Junio seems to think otherwise, but to me it would be clearer if this would be clearly spelled out:
Defaults to 'on-demand', or to the value of 'submodule.recurse' if set.