Re: [PATCH v3 3/5] doc: explain how to deactivate submodule.recurse completely

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Mar 22, 2020, 22:36 UTC
Message-ID: <934EF1ED-E2A9-4561-8A3D-1B0F71129252@gmail.com>
In-Reply-To: <20200320213729.571924-4-damien.olivier.robert+git@gmail.com>

Show 5 quoted lines

> Le 20 mars 2020 à 17:37, Damien Robert <damien.olivier.robert@gmail.com> a écrit :
> 
> +	When set to true, it can be deactivated via the
> +	`--no-recurse-submodules` option. Note that some Git commands
> +	without this option may call some of the above commands affected by

For clarity I'd write "some Git commands lacking this option" instead, as "without this option" *could* be interpreted as "invoked without this option".

> +	`submodule.recurse`; for instance `git remote update` will call
> +	`git fetch` but does not have a `--no-recurse-submodules` option.
> +	In this case a solution

I'm not sure "solution" is the best word here, maybe:

"For these commands a workaround is to temporarily change the configuration..."

Note: s/temporary/temporarily/

> is to temporary change the configuration
> +	value by using `git -c submodule.recurse=0`.