Re: [PATCH 2/2] config: allow specifying config entries via envvar pairs

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2020, 16:01 UTC
Message-ID: <xmqqo8ju3b7w.fsf@gitster.c.googlers.com>
In-Reply-To: <87d00arczw.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 10 quoted lines

> Nobody in this thread has mentioned GIT_PUSH_OPTION_* which works pretty
> much like Patrick's suggestion, and it looks like --local-env-vars
> misses those:
>
>     $ GIT_PUSH_OPTION_0=foo GIT_PUSH_OPTION_COUNT=20 git rev-parse --local-env-vars | grep GIT_PUSH
>     $
>
> I haven't tested this, but I expect there's a bug where a push hook
> itself does a local push to another repo and that repo has a hook, that
> the push options are erroneously carried forward to the sub-process.

True.

Nobody mentioned the environment variable in the discussion, and nobody discovered and was motivated enough to report and/or fix it, may be a good indication that these variables are not much used in real life and certainly not in combination with hooks that further push things out.