Re: [PATCH 2/2] config: allow specifying config entries via envvar pairs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2020, 07:06 UTC
- Message-ID
- <xmqq4klo7992.fsf@gitster.c.googlers.com>
- In-Reply-To
- <X7NtovvfE7IjWzie@ncase>
Patrick Steinhardt <ps@pks.im> writes:
Show 10 quoted lines
>> I especially do not think we want to read from unbounded number of >> GIT_CONFIG_KEY_<N> variables like this patch does. How would a >> script cleanse its environment to protect itself from stray such >> environment variable pair? Count up from 1 to forever? Run "env" >> and grep for "GIT_CONFIG_KEY_[0-9]*=" (the answer is No. What if >> some environment variables have newline in its values?) > > You only have to unset `GIT_CONFIG_KEY_1` as the parser will stop > iterating on the first missing key. More generally, if you set `n` keys, > it's sufficient to unset key `n+1`.
Yes, but those who want to set N keys would likely to be content with setting 1..N and happily forget unsetting N+1, and that is where "how would one cleanse the environment to give a clean slate?" comes from.