git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] config: allow specifying config entries via envvar pairs

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2020, 07:06 UTC
Message-ID
<xmqq4klo7992.fsf@gitster.c.googlers.com>
In-Reply-To
<X7NtovvfE7IjWzie@ncase>
Patrick Steinhardt <ps@pks.im> writes:
Show 10 quoted lines
>> I especially do not think we want to read from unbounded number of
>> GIT_CONFIG_KEY_<N> variables like this patch does.  How would a
>> script cleanse its environment to protect itself from stray such
>> environment variable pair?  Count up from 1 to forever?  Run "env"
>> and grep for "GIT_CONFIG_KEY_[0-9]*=" (the answer is No.  What if
>> some environment variables have newline in its values?)
>
> You only have to unset `GIT_CONFIG_KEY_1` as the parser will stop
> iterating on the first missing key. More generally, if you set `n` keys,
> it's sufficient to unset key `n+1`.

Yes, but those who want to set N keys would likely to be content with setting 1..N and happily forget unsetting N+1, and that is where "how would one cleanse the environment to give a clean slate?" comes from.

Previous: Patrick SteinhardtNext: Ævar Arnfjörð Bjarmason
Message 20 of 27 in “config: allow specifying config entries via envvar pairs”
  1. 0/2 config: allow specifying config entries via envvar pairsPatrick Steinhardt, Nov 13, 2020
  2. 1/2 config: extract function to parse config pairsPatrick Steinhardt, Nov 13, 2020
  3. 2/2 config: allow specifying config entries via envvar pairsPatrick Steinhardt, Nov 13, 2020
  4. Ævar Arnfjörð BjarmasonNov 13, 2020
  5. Junio C HamanoNov 16, 2020
  6. Jeff KingNov 17, 2020
  7. Patrick SteinhardtNov 17, 2020
  8. Jeff KingNov 17, 2020
  9. Ævar Arnfjörð BjarmasonNov 17, 2020
  10. Jeff KingNov 17, 2020
  11. Ævar Arnfjörð BjarmasonNov 18, 2020
  12. brian m. carlsonNov 18, 2020
  13. Jeff KingNov 18, 2020
  14. brian m. carlsonNov 18, 2020
  15. Patrick SteinhardtNov 18, 2020
  16. brian m. carlsonNov 19, 2020
  17. Patrick SteinhardtNov 19, 2020
  18. Junio C HamanoNov 18, 2020
  19. Patrick SteinhardtNov 17, 2020
  20. Junio C HamanoNov 17, 2020
  21. Ævar Arnfjörð BjarmasonNov 18, 2020
  22. Patrick SteinhardtNov 18, 2020
  23. Junio C HamanoNov 18, 2020
  24. Ævar Arnfjörð BjarmasonNov 17, 2020
  25. Philip OakleyNov 13, 2020
  26. Patrick SteinhardtNov 17, 2020
  27. Ævar Arnfjörð BjarmasonNov 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.