Re: [PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 15, 2021, 02:22 UTC
Message-ID: <xmqqo8hruef3.fsf@gitster.c.googlers.com>
In-Reply-To: <YACmcG4bNugX3WfK@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 19 quoted lines

> On Thu, Jan 14, 2021 at 03:11:10PM -0500, Jeff King wrote:
>> On Thu, Jan 14, 2021 at 02:33:53PM -0500, Jeff King wrote:
>>
>> > So "pos" in this case is not wrong. But I agree that it could stand to
>> > be more clear. Saying "nth" does not help things IMHO (there is an "nth"
>> > pack position, as well).
>> >
>> > But maybe this makes it more clear (or possibly just the name change
>> > without the comment):
>>
>> Here it is again, but with a signoff and commit message, and done on top
>> of your series (so if we agree this is a good resolution, it can just be
>> picked up on top, but I am also happy for it to be squashed into patch
>> 15).
>
> Much appreciated. This looks good to me (and I have no opinion whether
> it is picked up on top, or squashed into patch 15).
>
>   Acked-by: Taylor Blau <me@ttaylorr.com>

OK, so I'll make this 21/20 and rebase the other one...