Re: [PATCH 05/20] check_object(): convert to new revindex API
On Fri, Jan 08, 2021 at 01:17:00PM -0500, Taylor Blau wrote:
Show 8 quoted lines
> Replace direct accesses to the revindex with calls to
> 'offset_to_pack_pos()' and 'pack_pos_to_index()'.
>
> Since this caller already had some error checking (it can jump to the
> 'give_up' label if it encounters an error), we can easily check whether
> or not the provided offset points to an object in the given pack. This
> error checking existed prior to this patch, too, since the caller checks
> whether the return value from 'find_pack_revindex()' was NULL or not.
Yay. Happy again to see things getting more robust.
-Peff