Re: [GSoC] [PATCH v2 2/4] submodule: prefix die messages with 'fatal'

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 8, 2021, 15:17 UTC
Message-ID: <xmqqo8bcbzrx.fsf@gitster.g>
In-Reply-To: <20210708095533.26226-3-raykar.ath@gmail.com>

Atharva Raykar <raykar.ath@gmail.com> writes:

Show 7 quoted lines

> The standard `die()` function that is used in C code prefixes all the
> messages passed to it with 'fatal: '. This does not happen with the
> `die` used in 'git-submodule.sh'.
>
> Let's prefix each of the shell die messages with 'fatal: ' so that when
> they are converted to C code, the error messages stay the same as before
> the conversion.

Sounds good. More importantly, the error messages from the resulting system would become more uniform---after all, the end users would not care if scripted part of the system is emitting the error messages, or the message comes from a built-in version.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.