From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 Jul 2021 15:17:54 GMT
Subject: Re: [GSoC] [PATCH v2 2/4] submodule: prefix die messages with 'fatal'
Message-ID: <xmqqo8bcbzrx.fsf@gitster.g>
In-Reply-To: <20210708095533.26226-3-raykar.ath@gmail.com>

Atharva Raykar <raykar.ath@gmail.com> writes:

> The standard `die()` function that is used in C code prefixes all the
> messages passed to it with 'fatal: '. This does not happen with the
> `die` used in 'git-submodule.sh'.
>
> Let's prefix each of the shell die messages with 'fatal: ' so that when
> they are converted to C code, the error messages stay the same as before
> the conversion.

Sounds good.  More importantly, the error messages from the
resulting system would become more uniform---after all, the end
users would not care if scripted part of the system is emitting the
error messages, or the message comes from a built-in version.