Re: [PATCH v3 2/2] lazyload.h: use an even more generic function pointer than FARPROC
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 27, 2021, 20:13 UTC
- Message-ID
- <xmqqo88dpyiz.fsf@gitster.g>
- In-Reply-To
- <CAPUEspif_MAg1==aNWT4q1spOFbsp0cUfr+JjPdc2RLy4F4L1A@mail.gmail.com>
Carlo Arenas <carenas@gmail.com> writes:
Show 14 quoted lines
> On Mon, Sep 27, 2021 at 9:35 AM Junio C Hamano <gitster@pobox.com> wrote: >> >> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes: >> >> > Because of the way the function declaration was done in the previous >> > patch the order of variables that use it had to be adjusted so that >> > it is the last variable declared, as well. >> >> Is it clear to everybody what this paragraph is referring to? It is >> not, at least to me. > > It is not, and it is no longer needed after the fixup was applied to > the previous > patch.
Ah, yes, the previous one's definition is quite awkward because you had to omit the terminating ';' to use it.
I'll drop the paragraph with "commit --amend".
THanks.