Re: [PATCH v3 2/2] lazyload.h: use an even more generic function pointer than FARPROC
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 27, 2021, 16:35 UTC
- Message-ID
- <xmqqk0j2q8m3.fsf@gitster.g>
- In-Reply-To
- <20210926100512.58924-3-carenas@gmail.com>
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
Show 10 quoted lines
> gcc will helpfully raise a -Wcast-function-type warning when casting > between functions that might have incompatible return types > (ex: GetUserNameExW returns bool which is only half the size of the > return type from FARPROC which is long long), so create a new type that > could be used as a completely generic function pointer and cast through > it instead. > > Because of the way the function declaration was done in the previous > patch the order of variables that use it had to be adjusted so that > it is the last variable declared, as well.
Is it clear to everybody what this paragraph is referring to? It is not, at least to me.
Show 9 quoted lines
> > Additionaly remove the -Wno-incompatible-pointer-types temporary > flag added in 27e0c3c (win32: allow building with pedantic mode > enabled, 2021-09-03), as it will be no longer needed. > > Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> > --- > v3 > - removes unnecessary variable moving after fixup in previous patch
Thanks.