[PATCH v5 0/3] js/win-lazyload-buildfix
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- Sep 29, 2021, 03:19 UTC
- Message-ID
- <20210929031940.97092-1-carenas@gmail.com>
- In-Reply-To
- <20210929004832.96304-1-carenas@gmail.com>
This is a reroll of v3, merged in seen at 906546091d (Merge branch 'js/win-lazyload-buildfix' into jch, 2021-09-28) and that provides a buildfix for a non standard setup found and provided by Hannes, plus cleanup for confusing issues reported by Ævar and Jonathan Tan due to the original implementation of cb/pedantic-build-for-developers now in master.
v5 - remove unnecessary export of a make variable as suggested by Ramsay
v4 - add a third patch based on feedback from cb/pedantic-build-for-developers in master and including suggestions by Ævar on a similar patch posted as part of a different series.
v3 - fixup to patch1 to help usability and typo fixes from Eric and Junio.
v2 - add a second patch to avoid CI build issues caused by the first and retire now obsoleted -Wno-incompatible-pointer-types.
v1 - first patch with a build fix when -Wno-incompatible-pointer-types (included with 6a8cbc41ba (developer: enable pedantic by default, 2021-09-03)) was not in effect.
Carlo Marcelo Arenas Belón (2): lazyload.h: use an even more generic function pointer than FARPROC Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better
Johannes Sixt (1): lazyload.h: fix warnings about mismatching function pointer types
compat/win32/lazyload.h | 14 +++++++++----- config.mak.dev | 8 ++++++-- config.mak.uname | 6 +++++- 3 files changed, 20 insertions(+), 8 deletions(-)
Range-diff against v4:
1: d2c470f9bc = 1: d2c470f9bc lazyload.h: fix warnings about mismatching function pointer types
2: 2d84c4ed57 = 2: 2d84c4ed57 lazyload.h: use an even more generic function pointer than FARPROC
3: a731848d01 ! 3: 0d4f097db9 Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better
@@ config.mak.uname: ifeq ($(uname_S),NONSTOP_KERNEL)
pathsep = ;
HAVE_ALLOCA_H = YesPlease
NO_PREAD = YesPlease
-@@ config.mak.uname: ifeq ($(uname_S),QNX)
- NO_STRLCPY = YesPlease
- endif
-
-+export uname_S
-+
- vcxproj:
- # Require clean work tree
- git update-index -q --refresh && \-- 2.33.0.955.gee03ddbf0e