Re: [PATCH v3 0/3] sparse-checkout: fix segfault on malformed patterns
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 16, 2021, 19:16 UTC
- Message-ID
- <xmqqo85gbbsd.fsf@gitster.g>
- In-Reply-To
- <e0f90c01-f987-1c9c-cd93-393d0dc6e0dc@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 6 quoted lines
>> Thanks. The segfault fix matters even more with Elijah's "we can >> flip between modes" feature, right? > > Generally, I think segfaults are a higher priority, but this one is hard > to find in the wild, I think. I'll send a v4 today and hopefully it makes > it an easy decision for you.
I agree about the priority and I was assuming that the topics do not have semantic conflicts we cannot reconcile, but I do not offhand recall what the other topic did when there patterns unsuitable in the cone mode when transitioning to the cone mode (or vice-versa for that matter).