Re: [PATCH v3 0/3] sparse-checkout: fix segfault on malformed patterns

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 16, 2021, 14:24 UTC
Message-ID: <e0f90c01-f987-1c9c-cd93-393d0dc6e0dc@gmail.com>
In-Reply-To: <xmqq5yrp61lw.fsf@gitster.g>

On 12/15/2021 3:43 PM, Junio C Hamano wrote:

Show 14 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> This series fixes some issues with parsing sparse-checkout patterns when
>> core.sparseCheckoutCone is enabled but the sparse-checkout file itself
>> contains patterns that don't match the cone mode format.
>>
>> The first patch fixes a segfault first reported in [1]. The other two
>> patches are from an earlier submission [2] that never got picked up and I
>> lost track of. There was another patch involving 'git sparse-checkout init
>> --cone' that isn't necessary, especially with Elijah doing some work in that
>> space right now.
> 
> Thanks.  The segfault fix matters even more with Elijah's "we can
> flip between modes" feature, right?

Generally, I think segfaults are a higher priority, but this one is hard to find in the wild, I think. I'll send a v4 today and hopefully it makes it an easy decision for you.

Thanks, -Stolee