Re: [PATCH 0/3] sparse-checkout: fix segfault on malformed patterns

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 8, 2021, 14:23 UTC
Message-ID: <63bae98d-5c81-a6e4-5364-a643dbe4ef5e@gmail.com>
In-Reply-To: <CABPp-BF-xvJzfWO33p1ODtkLGMy2KENAbEu7KnrxPNq7UubbFg@mail.gmail.com>

On 12/7/2021 4:51 PM, Elijah Newren wrote:

Show 9 quoted lines

> On Tue, Dec 7, 2021 at 12:02 PM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> This series fixes some issues with parsing sparse-checkout patterns when
>> core.sparseCheckoutCone is enabled but the sparse-checkout file itself
>> contains patterns that don't match the cone mode format.
> 
> I was only able to find what I think is a small typo in one of the
> commits.  Everything else looks good to me.

Thanks. I'll give this a few more days for more feedback before sending
a v2 with that fix.

Show 5 quoted lines

>> The first patch fixes a segfault first reported in [1]. The other two
>> patches are from an earlier submission [2] that never got picked up and I
>> lost track of. There was another patch involving 'git sparse-checkout init
> 
> Sorry for missing that series earlier.  Glad we've got some of them now.

The fault was my own for dropping this during a particularly busy time.

Thanks, -Stolee