git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] list-objects-filter: handle null default filter spec

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 12, 2022, 16:56 UTC
Message-ID
<xmqqo7vkfs58.fsf@gitster.g>
In-Reply-To
<Yx1rfYtQAlZGfAak@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> But it's probably worth avoiding this confused state. It's an accident
> waiting to happen, and it will be a problem if we replace the lazy
> initialization from 7e2619d8ff (list_objects_filter_options: plug leak
> of filter_spec strings, 2022-09-08) with a real initialization function.
True.  Thanks for a careful analysis.
Previous: Jeff KingNext: Jeff King
Message 5 of 11 in “list-objects-filter cleanups”
  1. 0/4 list-objects-filter cleanupsJeff King, Sep 11, 2022
  2. 1/4 list-objects-filter: don't memset after releasing filter structJeff King, Sep 11, 2022
  3. Junio C HamanoSep 12, 2022
  4. 2/4 list-objects-filter: handle null default filter specJeff King, Sep 11, 2022
  5. Junio C HamanoSep 12, 2022
  6. 3/4 list-objects-filter: add and use initializersJeff King, Sep 11, 2022
  7. 4/4 list-objects-filter: convert filter_spec to a strbufJeff King, Sep 11, 2022
  8. Derrick StoleeSep 19, 2022
  9. Jeff KingSep 19, 2022
  10. Jeff KingSep 11, 2022
  11. Derrick StoleeSep 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.