git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] list-objects-filter cleanups

From
Derrick Stolee <derrickstolee@github.com>
Date
Sep 19, 2022, 17:51 UTC
Message-ID
<a0d692da-9910-9c43-d710-6cfe739ce09e@github.com>
In-Reply-To
<Yx1qwlpNbxGEiUgc@coredump.intra.peff.net>
On 9/11/2022 12:57 AM, Jeff King wrote:
Show 14 quoted lines
> In the recent jk/plug-list-object-filter-leaks topic[1], I stopped short
> of fixing all of the callers to actually initialize the filter struct
> beyond zero-ing it.
> 
> This series does the cleanup that I was afraid to do there. :)
> 
> I think the end result is less confusing and error-prone. And as you can
> see in patch 4, it matches how the code originally hoped to be written,
> but the author was also afraid of the zero-initialization thing.
> 
> It is kind of churny, and carries some risk of regression (if I missed a
> spot). IMHO it's worth it, but even if we don't take it, we should pick
> up the first two patches, which are small bug-lets that the conversion
> turned up.

I agree that it's worth it. Hopefully the BUG() you inserted is sufficient to catch any regression in CI.

Thanks, -Stolee

Previous: Jeff King
Message 11 of 11 in “list-objects-filter cleanups”
  1. 0/4 list-objects-filter cleanupsJeff King, Sep 11, 2022
  2. 1/4 list-objects-filter: don't memset after releasing filter structJeff King, Sep 11, 2022
  3. Junio C HamanoSep 12, 2022
  4. 2/4 list-objects-filter: handle null default filter specJeff King, Sep 11, 2022
  5. Junio C HamanoSep 12, 2022
  6. 3/4 list-objects-filter: add and use initializersJeff King, Sep 11, 2022
  7. 4/4 list-objects-filter: convert filter_spec to a strbufJeff King, Sep 11, 2022
  8. Derrick StoleeSep 19, 2022
  9. Jeff KingSep 19, 2022
  10. Jeff KingSep 11, 2022
  11. Derrick StoleeSep 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.