Re: [PATCH 0/4] list-objects-filter cleanups
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Sep 19, 2022, 17:51 UTC
- Message-ID
- <a0d692da-9910-9c43-d710-6cfe739ce09e@github.com>
- In-Reply-To
- <Yx1qwlpNbxGEiUgc@coredump.intra.peff.net>
On 9/11/2022 12:57 AM, Jeff King wrote:
Show 14 quoted lines
> In the recent jk/plug-list-object-filter-leaks topic[1], I stopped short > of fixing all of the callers to actually initialize the filter struct > beyond zero-ing it. > > This series does the cleanup that I was afraid to do there. :) > > I think the end result is less confusing and error-prone. And as you can > see in patch 4, it matches how the code originally hoped to be written, > but the author was also afraid of the zero-initialization thing. > > It is kind of churny, and carries some risk of regression (if I missed a > spot). IMHO it's worth it, but even if we don't take it, we should pick > up the first two patches, which are small bug-lets that the conversion > turned up.
I agree that it's worth it. Hopefully the BUG() you inserted is sufficient to catch any regression in CI.
Thanks, -Stolee