Re: [PATCH 0/4] list-objects-filter cleanups

From: Jeff King <peff@peff.net>
Date: Sep 11, 2022, 05:07 UTC
Message-ID: <Yx1tD7MLGZnZ/RHa@coredump.intra.peff.net>
In-Reply-To: <Yx1qwlpNbxGEiUgc@coredump.intra.peff.net>

On Sun, Sep 11, 2022 at 12:57:39AM -0400, Jeff King wrote:

Show 7 quoted lines

> These patches should be applied on top of jk/plug-list-object-filter-leaks,
> which is currently in next.
> 
>   [1/4]: list-objects-filter: don't memset after releasing filter struct
>   [2/4]: list-objects-filter: handle null default filter spec
>   [3/4]: list-objects-filter: add and use initializers
>   [4/4]: list-objects-filter: convert filter_spec to a strbuf

By the way, there are two small conflicts when merging the result to next. In ab/submodule-helper-leakfix, some memset() calls got moved to "{ 0 }" initializers in the variable declarations. The resolution is to just replace the "{ 0 }" with LIST_OBJECTS_FILTER_INIT (both sides remove the memset calls).

-Peff