Re: tb/ban-strtok

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 18, 2023, 16:58 UTC
Message-ID: <xmqqo7nldt5f.fsf@gitster.g>
In-Reply-To: <ZD6vu6H0xzLSF/2w@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 7 quoted lines

>>  Mark strtok() and strtok_r() to be banned.
>>
>>  source: <cover.1681428696.git.me@ttaylorr.com>
>
> This one needs a reroll to remove `strtok_r()` from the proposed banned
> list, and to support slightly different semantics the new
> string_list_split_in_place_multi() function. Will send today.

I actually do not think we would seriously miss strtok_r(); as long as the rationale for doing so is clearly described, I think we are OK. Just do not sell string-list as if it were the solution to everything (which is not---it is a rather poor data structure), but compare string_list_split() with strtok_r() and say our application hasn't needed the flexibility of the latter.

Thanks.