tb/ban-strtok (was: Re: What's cooking in git.git (Apr 2023, #05; Mon, 17))

From: Taylor Blau <me@ttaylorr.com>
Date: Apr 18, 2023, 14:56 UTC
Message-ID: <ZD6vu6H0xzLSF/2w@nand.local>
In-Reply-To: <xmqqfs8xfw25.fsf@gitster.g>

On Tue, Apr 18, 2023 at 01:12:34AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> * tb/ban-strtok (2023-04-14) 5 commits
>  - banned.h: mark `strtok()`, `strtok_r()` as banned
>  - t/helper/test-json-writer.c: avoid using `strtok()`
>  - t/helper/test-oidmap.c: avoid using `strtok()`
>  - t/helper/test-hashmap.c: avoid using `strtok()`
>  - string-list: introduce `string_list_split_in_place_multi()`
>
>  Mark strtok() and strtok_r() to be banned.
>
>  source: <cover.1681428696.git.me@ttaylorr.com>

This one needs a reroll to remove `strtok_r()` from the proposed banned list, and to support slightly different semantics the new string_list_split_in_place_multi() function. Will send today.

Thanks, Taylor