git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: tb/ban-strtok

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 18, 2023, 19:31 UTC
Message-ID
<ZD7wCYDmhiKcfhow@nand.local>
In-Reply-To
<xmqqo7nldt5f.fsf@gitster.g>
On Tue, Apr 18, 2023 at 09:58:20AM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Taylor Blau <me@ttaylorr.com> writes:
>
> >>  Mark strtok() and strtok_r() to be banned.
> >>
> >>  source: <cover.1681428696.git.me@ttaylorr.com>
> >
> > This one needs a reroll to remove `strtok_r()` from the proposed banned
> > list, and to support slightly different semantics the new
> > string_list_split_in_place_multi() function. Will send today.
>
> I actually do not think we would seriously miss strtok_r(); as long
> as the rationale for doing so is clearly described, I think we are
> OK.  Just do not sell string-list as if it were the solution to
> everything (which is not---it is a rather poor data structure), but
> compare string_list_split() with strtok_r() and say our application
> hasn't needed the flexibility of the latter.

I agree that we wouldn't miss it at all, since we have no uses of strtok_r() today.

But let's decide on banning it separately, since the much more immediate-term issues are the existing uses of strtok() that are in the tree.

Thanks, Taylor

Previous: Junio C HamanoNext: Elijah Newren
Message 6 of 8 in “What's cooking in git.git (Apr 2023, #05; Mon, 17)”
  1. Junio C HamanoApr 18, 2023
  2. tb/pack-revindex-on-disk (was: Re: What's cooking in git.git (Apr 2023, #05; Mon, 17))Taylor Blau, Apr 18, 2023
  3. tb/enable-cruft-packs-by-default (was: Re: What's cooking in git.git (Apr 2023, #05; Mon, 17))Taylor Blau, Apr 18, 2023
  4. tb/ban-strtok (was: Re: What's cooking in git.git (Apr 2023, #05; Mon, 17))Taylor Blau, Apr 18, 2023
  5. Junio C HamanoApr 18, 2023
  6. Taylor BlauApr 18, 2023
  7. en/header-split-cache-h (Was Re: What's cooking in git.git (Apr 2023, #05; Mon, 17))Elijah Newren, Apr 19, 2023
  8. rj/branch-unborn-in-other-worktrees (was Re: What's cooking in git.git (Apr 2023, #05; Mon, 17))Rubén Justo, Apr 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.