git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http: preserve wwwauth_headers across redirects

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2026, 19:16 UTC
Message-ID
<xmqqo6gi3905.fsf@gitster.g>
In-Reply-To
<5144a29d-a53f-4446-beff-e1f549345bf9@nvidia.com>
Aaron Plattner <aplattner@nvidia.com> writes:
Show 10 quoted lines
>> I wonder if it would make the design more robust and future-proof to
>> encapsulate this logic in credential.c instead.  For example, we
>> could introduce a helper function:
>> 
>>      void credential_update_url(struct credential *c, const char *url)
>> 
>> that does what the new code added around credential_from_url() by
>> this patch does, perhaps?
>
> Yeah, maybe. I'll think about this design some more.
Sorry, I lost track.

Did anything come of that discussion? No rush, since this change fixes an immediate issue and the helper suggestion is for long-term future-proofing. We can treat them as separate steps.

Thanks.
Previous: Aaron PlattnerNext: Aaron Plattner
Message 4 of 6 in “http: preserve wwwauth_headers across redirects”
  1. http: preserve wwwauth_headers across redirectsAaron Plattner, Jun 2, 2026
  2. Junio C HamanoJun 3, 2026
  3. Aaron PlattnerJun 3, 2026
  4. Junio C HamanoJul 7, 2026
  5. Aaron PlattnerJul 7, 2026
  6. Junio C HamanoJul 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.