From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 Jul 2026 19:16:58 GMT
Subject: Re: [PATCH] http: preserve wwwauth_headers across redirects
Message-ID: <xmqqo6gi3905.fsf@gitster.g>
In-Reply-To: <5144a29d-a53f-4446-beff-e1f549345bf9@nvidia.com>

Aaron Plattner <aplattner@nvidia.com> writes:

>> I wonder if it would make the design more robust and future-proof to
>> encapsulate this logic in credential.c instead.  For example, we
>> could introduce a helper function:
>> 
>>      void credential_update_url(struct credential *c, const char *url)
>> 
>> that does what the new code added around credential_from_url() by
>> this patch does, perhaps?
>
> Yeah, maybe. I'll think about this design some more.

Sorry, I lost track.

Did anything come of that discussion?  No rush, since this change
fixes an immediate issue and the helper suggestion is for long-term
future-proofing.  We can treat them as separate steps.

Thanks.