git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http: preserve wwwauth_headers across redirects

From
Aaron Plattner <aplattner@nvidia.com>
Date
Jul 7, 2026, 19:21 UTC
Message-ID
<68c2b88f-8976-474b-8965-97733eba5a99@nvidia.com>
In-Reply-To
<xmqqo6gi3905.fsf@gitster.g>
On 7/7/26 12:16 PM, Junio C Hamano wrote:
Show 20 quoted lines
> Aaron Plattner <aplattner@nvidia.com> writes:
> 
>>> I wonder if it would make the design more robust and future-proof to
>>> encapsulate this logic in credential.c instead.  For example, we
>>> could introduce a helper function:
>>>
>>>       void credential_update_url(struct credential *c, const char *url)
>>>
>>> that does what the new code added around credential_from_url() by
>>> this patch does, perhaps?
>>
>> Yeah, maybe. I'll think about this design some more.
> 
> Sorry, I lost track.
> 
> Did anything come of that discussion?  No rush, since this change
> fixes an immediate issue and the helper suggestion is for long-term
> future-proofing.  We can treat them as separate steps.
> 
> Thanks.

No, I got sidetracked with other work and didn't get a chance to get back to this, sorry. It's not directly impacting my users since I can just tell them they have to use my server's FQDN, so fine with me to treat this as a low-priority issue.

-- Aaron
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “http: preserve wwwauth_headers across redirects”
  1. http: preserve wwwauth_headers across redirectsAaron Plattner, Jun 2, 2026
  2. Junio C HamanoJun 3, 2026
  3. Aaron PlattnerJun 3, 2026
  4. Junio C HamanoJul 7, 2026
  5. Aaron PlattnerJul 7, 2026
  6. Junio C HamanoJul 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.