Re: [RFC PATCH] git log: support "auto" decorations

From: Junio C Hamano <gitster@pobox.com>
Date: May 30, 2014, 17:35 UTC
Message-ID: <xmqqmwdz9nl9.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140530170330.GA25443@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> On Fri, May 30, 2014 at 09:55:14AM -0700, Junio C Hamano wrote:
>
> I don't think we need to worry about commit->buffer being mucked with.
> It is always either NULL, or points to the original object contents.
> Encoded log messages are always placed in a separate buffer (and in fact
> we use the same "optionally point to commit->buffer" trick there). And
> things like mucking with parents always happen on the parsed form.
>
> Of course I may be missing a site, and it's certainly a maintenance risk
> for the future. But I'd go so far as to say that anything modifying
> commit->buffer is wrong, and that side should be fixed.

I fully agree, and "that side should be fixed" implying "we should always be on a look-out for such a change" is something the lazyness tried to avoid.

> Do you want me to roll it up with a real commit message?

Yes.  I think the change is sensible.