git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] git log: support "auto" decorations

From
Junio C Hamano <gitster@pobox.com>
Date
May 30, 2014, 20:52 UTC
Message-ID
<xmqqfvjr7zwk.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqqmwdz809b.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
> Jeff King <peff@peff.net> writes:
>
>> Subject: [PATCH] reuse commit->buffer when parsing signatures
>> ...
>> Signed-off-by: Jeff King <peff@peff.net>
>
> Hmph, unfortunately this seems to break t7510.

And I think without re-reading the patch I know what is wrong. The length of the object and strlen(commit->buffer) would be different, no?

Previous: Junio C Hamano
Message 13 of 13 in “git log: support "auto" decorations”
  1. git log: support "auto" decorationsLinus Torvalds, May 29, 2014
  2. Jeff KingMay 30, 2014
  3. Linus TorvaldsMay 30, 2014
  4. Jeff KingMay 30, 2014
  5. Junio C HamanoMay 30, 2014
  6. Jeff KingMay 30, 2014
  7. Junio C HamanoMay 30, 2014
  8. Jeff KingMay 30, 2014
  9. Jeff KingMay 30, 2014
  10. Junio C HamanoMay 30, 2014
  11. Jeff KingMay 30, 2014
  12. Junio C HamanoMay 30, 2014
  13. Junio C HamanoMay 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.