Re: [RFC PATCH] git log: support "auto" decorations

From: Jeff King <peff@peff.net>
Date: May 30, 2014, 20:48 UTC
Message-ID: <20140530204853.GA9271@sigill.intra.peff.net>
In-Reply-To: <xmqqmwdz809b.fsf@gitster.dls.corp.google.com>

On Fri, May 30, 2014 at 01:44:32PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Subject: [PATCH] reuse commit->buffer when parsing signatures
> > ...
> > Signed-off-by: Jeff King <peff@peff.net>
> 
> Hmph, unfortunately this seems to break t7510.

Urgh, sorry for not testing more thoroughly.

I imagine it is because of the strlen(commit->buffer) I introduced. Unfortunately I do not know if we have an easy way to know the length of commit->buffer, short of hitting sha1_object_info (which is somewhat expensive to do for every commit).

I wonder if it would be sane to remove or quote NULs when attaching the buffer to commit->buffer. That would _break_ signatures, but that is a good thing. I do not think there is a reason to have NULs in your commit message unless you are doing something malicious (or using utf16, but that already is horribly broken).

-Peff