Re: [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 23, 2016, 20:28 UTC
Message-ID: <xmqqmvk3ut4s.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <01020156b73fe5b4-5dc768ab-b73b-4a21-ab92-018e2a7aa6f7-000000@eu-west-1.amazonses.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

Show 10 quoted lines

> `--next-all` is meant to be used as a subcommand to support multiple
> "operation mode" though the current implementation does not contain any
> other subcommand along side with `--next-all` but further commits will
> include some more subcommands.
>
> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Mentored-by: Lars Schneider <larsxschneider@gmail.com>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
> ---

A series this size really needs a cover letter that describes what changes were made relative to the previous round to help reviewers.

I also noticed something curious.  All of your messages are dated

    Date: Tue, 23 Aug 2016 11:53:53 +0000

and I think that is the same as all the previous series, but how are you sending your patches? The reason why I ask is because this does not allow readers to tell their mail reader to sort messages by the sender's timestamp in order to see the messages in order (as a matter of fact, git-send-email knows that readers are helped by this feature, and backdates the first message of 10 patch series by 10 seconds, stamps the second message as later than the first by one second, etc. to help them).