Re: [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Aug 23, 2016, 21:24 UTC
- Message-ID
- <CAFZEwPM6hDbiEVMbe_FakME4h_RNCopyzFcVLsF1PB=V=OheOA@mail.gmail.com>
- In-Reply-To
- <01020156b73fe5b4-5dc768ab-b73b-4a21-ab92-018e2a7aa6f7-000000@eu-west-1.amazonses.com>
Hey everyone,
Sending a "cover letter" to this series.
Changes with wrt v12[1] are:
* Rebased on v2.10-rc0
* Two function signatures had changed while the topic
develop so changed those.
* Correct the "mark for translation" messages properly as
I had previously used N_() in some places but I had to
actually use _().
* In the patch 04/27[2], bisect_clean_state() is put in bisect.c
rather than builtin/bisect--helper.c because I will need it
further when porting bisect_next() function.
* The patches from 14th are completely new to the series.
They port even more functions and remove some then unused
subcommands.
* 14th patch[3] is a tricky one as it changes a lot of things. I am
not sure whether to put this all in one patch or split it.[1]: http://public-inbox.org/git/010201567675adc1-17e27495-6b36-40d1-836d-814da029fcc4-000000@eu-west-1.amazonses.com/ [2]: http://public-inbox.org/git/01020156b73fe66f-bfad6316-39d4-4577-8f75-d1b4b2031263-000000@eu-west-1.amazonses.com/ [3]: http://public-inbox.org/git/01020156b73fe6ce-3b204354-849b-40fd-93ff-2ebcf77df91c-000000@eu-west-1.amazonses.com/
Regards, Pranit Bauva