Re: [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Aug 23, 2016, 21:07 UTC
- Message-ID
- <CAFZEwPPUasJvZO=LHOzu85FwPAsg-OQo57wQckXJdiHTP4_34A@mail.gmail.com>
- In-Reply-To
- <xmqqmvk3ut4s.fsf@gitster.mtv.corp.google.com>
Hey Junio,
On Wed, Aug 24, 2016 at 1:58 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Pranit Bauva <pranit.bauva@gmail.com> writes: > >> `--next-all` is meant to be used as a subcommand to support multiple >> "operation mode" though the current implementation does not contain any >> other subcommand along side with `--next-all` but further commits will >> include some more subcommands. >> >> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> >> Mentored-by: Lars Schneider <larsxschneider@gmail.com> >> Mentored-by: Christian Couder <chriscool@tuxfamily.org> >> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> >> --- > > A series this size really needs a cover letter that describes what > changes were made relative to the previous round to help reviewers.
I am actually using SubmitGit these days as I am back in my campus and IMAP/SMTP connections are blocked here. SubmitGit doesn't have the option to include a cover letter. Though I can describe the changes by including a separate email as a reply to 1st patch. I will send the changes according to v12 since v13 wasn't commented on.
Show 12 quoted lines
> I also noticed something curious. All of your messages are dated > > Date: Tue, 23 Aug 2016 11:53:53 +0000 > > and I think that is the same as all the previous series, but how are > you sending your patches? The reason why I ask is because this does > not allow readers to tell their mail reader to sort messages by the > sender's timestamp in order to see the messages in order (as a > matter of fact, git-send-email knows that readers are helped by this > feature, and backdates the first message of 10 patch series by 10 > seconds, stamps the second message as later than the first by one > second, etc. to help them).
This might be a bug in SubmitGit. I didn't notice this previously.
Regards, Pranit Bauva