git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 26, 2017, 01:58 UTC
Message-ID
<xmqqmvb4szef.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CACBZZX494g8CKoN0V1N4xRuDsErPtJcMjaZcLFAqJgDQ+Mz+yA@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Indeed, I've tried to be careful not to introduce bugs like that, but
> in this skipped case the tests look completely stand-alone to me.

Yes, the ones I commented on in the upthread looked like their side effect were not felt in the later tests.

> In any case, I like my other patch to just remove this whole thing better.
Hmph, did I miss a patch message?
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 9 of 21 in “[BUG] test suite broken with GETTEXT_POISON=YesPlease”
  1. Ævar Arnfjörð BjarmasonApr 20, 2017
  2. Lars SchneiderApr 21, 2017
  3. Ævar Arnfjörð BjarmasonApr 21, 2017
  4. tests: fix tests broken under GETTEXT_POISON=YesPleaseÆvar Arnfjörð Bjarmason, Apr 21, 2017
  5. Junio C HamanoApr 24, 2017
  6. Ævar Arnfjörð BjarmasonApr 24, 2017
  7. Junio C HamanoApr 25, 2017
  8. Ævar Arnfjörð BjarmasonApr 25, 2017
  9. Junio C HamanoApr 26, 2017
  10. Ævar Arnfjörð BjarmasonApr 26, 2017
  11. Duy NguyenApr 24, 2017
  12. Jeff KingApr 24, 2017
  13. Lars SchneiderApr 25, 2017
  14. Jeff KingApr 25, 2017
  15. Lars SchneiderApr 28, 2017
  16. Jeff KingApr 28, 2017
  17. Michael J GruberApr 21, 2017
  18. Ævar Arnfjörð BjarmasonApr 21, 2017
  19. Junio C HamanoApr 24, 2017
  20. Michael J GruberApr 26, 2017
  21. Ævar Arnfjörð BjarmasonApr 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.