git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] test suite broken with GETTEXT_POISON=YesPlease

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 20, 2017, 21:58 UTC
Message-ID
<CACBZZX62+acvi1dpkknadTL827mtCm_QesGSZ=6+UnyeMpg8+Q@mail.gmail.com>

As a refresh of everyone's memory (because mine needed it). This is a feature I added back in 2011 when the i18n support was initially added.

There was concern at the time that we would inadvertently mark plumbing messages for translation, particularly something in a shared code path, and this was a way to hopefully smoke out those issues with the test suite.

However compiling with it breaks a couple of dozen tests, I stopped digging when I saw some broke back in 2014.

What should be done about this? I think if we're going to keep them they need to be run regularly by something like Travis (Lars CC'd), however empirical evidence suggests that not running them is just fine too, so should we just remove support for this test mode?

I don't care, but I can come up with the patch either way, but would only be motivated to write the one-time fix for it if some CI system is actually running them regularly, otherwise they'll just be subject to bitrotting again.

Next: Lars Schneider
Message 1 of 21 in “[BUG] test suite broken with GETTEXT_POISON=YesPlease”
  1. Ævar Arnfjörð BjarmasonApr 20, 2017
  2. Lars SchneiderApr 21, 2017
  3. Ævar Arnfjörð BjarmasonApr 21, 2017
  4. tests: fix tests broken under GETTEXT_POISON=YesPleaseÆvar Arnfjörð Bjarmason, Apr 21, 2017
  5. Junio C HamanoApr 24, 2017
  6. Ævar Arnfjörð BjarmasonApr 24, 2017
  7. Junio C HamanoApr 25, 2017
  8. Ævar Arnfjörð BjarmasonApr 25, 2017
  9. Junio C HamanoApr 26, 2017
  10. Ævar Arnfjörð BjarmasonApr 26, 2017
  11. Duy NguyenApr 24, 2017
  12. Jeff KingApr 24, 2017
  13. Lars SchneiderApr 25, 2017
  14. Jeff KingApr 25, 2017
  15. Lars SchneiderApr 28, 2017
  16. Jeff KingApr 28, 2017
  17. Michael J GruberApr 21, 2017
  18. Ævar Arnfjörð BjarmasonApr 21, 2017
  19. Junio C HamanoApr 24, 2017
  20. Michael J GruberApr 26, 2017
  21. Ævar Arnfjörð BjarmasonApr 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.