Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 26, 2017, 07:56 UTC
Message-ID: <CACBZZX5PgC3CjCrhhFb5d0z6-uMw2oR36-6H=78Q5eN20pKthg@mail.gmail.com>
In-Reply-To: <xmqqmvb4szef.fsf@gitster.mtv.corp.google.com>

On Wed, Apr 26, 2017 at 3:58 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Indeed, I've tried to be careful not to introduce bugs like that, but
>> in this skipped case the tests look completely stand-alone to me.
>
> Yes, the ones I commented on in the upthread looked like their side
> effect were not felt in the later tests.
>
>> In any case, I like my other patch to just remove this whole thing better.
>
> Hmph, did I miss a patch message?

I sent it to you & CC'd the list, but it looks like it didn't make it on-list. It's "[PATCH] tests: remove the GETTEXT_POISON compile-time option to test i18n marking" (<20170424110434.27689-1-avarab@gmail.com>). It's 240K & 6k lines, so perhaps the list is rejecting it, here's the patch:

https://raw.githubusercontent.com/avar/git-patches/master/remove-gettext-poison/0001-tests-remove-the-GETTEXT_POISON-compile-time-option-.patch