Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2017, 23:45 UTC
Message-ID: <xmqqmv9ows7h.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170531221151.pxdikxgxy37g7zub@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> ...
> That explains why you want to pass "-q" in the other hunk; to
> countermand the explicit --progress here. But if we separate the two as
> I mentioned above, you'd want logic more like:
>
>   if test -t 2 && test "$GIT_QUIET" != "t"
> 	git_format_patch_opt="$git_format_patch_opt --progress"
>   fi

This looks like a sensible line of thought. Kevin, do you want to try this again with the "explicit --progress option" approach? I think the gist of the v1 review is that everybody agrees that the end goal of showing a progress eye-candy from a long-running "format-patch" phase in a "rebase" is a good idea, but it is dubious "format-patch" should show it in cases other than when --progress is explicitly asked for.

Thanks.