Re: [PATCH v2 0/2] Add progress for format-patch and rebase

From: Jeff King <peff@peff.net>
Date: Aug 10, 2017, 23:17 UTC
Message-ID: <20170810231706.vixs6wms5cpwwsab@sigill.intra.peff.net>
In-Reply-To: <xmqqbmnn11kw.fsf@gitster.mtv.corp.google.com>

On Thu, Aug 10, 2017 at 03:48:31PM -0700, Junio C Hamano wrote:

Show 16 quoted lines

> Kevin Willford <kcwillford@gmail.com> writes:
> 
> > Changes since last patch:
> > 1. Use start_progress_delay so progress isn't shown if generating
> >    the patches is fast enough
> > 2. Updated to have text of "Generating patches"
> > 3. Only show progress when the --progress flag is passed
> > 4. In the rebase script check stderr and the quiet option is not
> >    set before propagating the progress flag to format-patch
> >
> > Kevin Willford (2):
> >   format-patch: have progress option while generating patches
> >   rebase: turn on progress option by default for format-patch
> 
> Do you have a pointer to the previous discussion handy (if you do
> not, that is OK---I think I can dig the list archive myself)?

https://public-inbox.org/git/20170531150427.7820-1-kewillf@microsoft.com/

is what I turned up.

Overall this version looks good to me, and addresses all of the previous points. I have two minor points which I'll make inline.

-Peff