Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

From: Stefan Beller <sbeller@google.com>
Date: May 31, 2017, 20:27 UTC
Message-ID: <CAGZ79kbmd7D5btJO5BWgOnSNUf221tYSYEUkgM9axzRPx7RnAQ@mail.gmail.com>
In-Reply-To: <SN2PR03MB23331225571F62753E88572CB7F10@SN2PR03MB2333.namprd03.prod.outlook.com>

On Wed, May 31, 2017 at 12:46 PM, Kevin Willford <kewillf@microsoft.com> wrote:

>
> I thought about that and certainly could do it but I have found it nice to have the number of patches that are generated in the output even for a small number or commits.  For example when I run a `git rebase master` and expect there to be only 2 commits, the message "Generating patch: 100% (2/2), done."  Gives me that good feeling that I did it right and didn't mess something up.  I'm good either way though.
>

Oh I see, that number matching makes sense. Though by reading the code, I have the impression that the final value would not change. So if it would take a really long time for these 2 patches, you'd still get the (2/2), to know it was 2 patches indeed.

When it goes quickly, I'd be more concerned about screen real estate, driving off the recent history from the screen.

Also we maybe want to have
 "Generating patches: 100% (2/2), done."
plural, as (when using the delay)
it is more likely to kick in for more than just one patch?

Sorry, if this comes across as bike shedding. It's meant as food for thought. :)

Thanks, Stefan