Re* [PATCH v2 2/2] t: add tests for pull --verify-signatures
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 15, 2017, 19:48 UTC
- Message-ID
- <xmqqmv2jpyb6.fsf_-_@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqbmj33h0s.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> Interestingly, the tests that do expect 'git pull' to succeed > protect themselves with "when-finished" mechanism correctly [*1*], > like so: > >> +test_expect_success GPG 'pull signed commit with --verify-signatures' ' >> + test_when_finished "git checkout initial" && >> + git pull --verify-signatures signed >pulloutput && >> + test_i18ngrep "has a good GPG signature" pulloutput >> +' >> + > > Other than that, looked nicely done. Thanks.
Here is what I would propose as a follow-up polishing.
-- >8 -- Subject: [PATCH 3/2] t5573: clean up after unexpected success of 'pull', too
The previous step added test_when_finished to tests that run 'git pull' with expectation of success, so that the test after them can start from a known state even when their 'git pull' invocation unexpectedly fails. However, tests that run 'git pull' expecting it not to succeed forgot to protect later tests the same way---if they unexpectedly succeed, the test after them would start from an unexpected state.
Reset and checkout the initial commit after all these tests, whether they expect their 'git pull' invocations to succeed or fail.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t5573-pull-verify-signatures.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t5573-pull-verify-signatures.sh b/t/t5573-pull-verify-signatures.sh index 8ae331f40e..9594e891f4 100755 --- a/t/t5573-pull-verify-signatures.sh +++ b/t/t5573-pull-verify-signatures.sh @@ -43,33 +43,36 @@ test_expect_success GPG 'create repositories with signed commits' ' ' test_expect_success GPG 'pull unsigned commit with --verify-signatures' ' + test_when_finished "git reset --hard && git checkout initial" && test_must_fail git pull --ff-only --verify-signatures unsigned 2>pullerror && test_i18ngrep "does not have a GPG signature" pullerror ' test_expect_success GPG 'pull commit with bad signature with --verify-signatures' ' + test_when_finished "git reset --hard && git checkout initial" && test_must_fail git pull --ff-only --verify-signatures bad 2>pullerror && test_i18ngrep "has a bad GPG signature" pullerror ' test_expect_success GPG 'pull commit with untrusted signature with --verify-signatures' ' + test_when_finished "git reset --hard && git checkout initial" && test_must_fail git pull --ff-only --verify-signatures untrusted 2>pullerror && test_i18ngrep "has an untrusted GPG signature" pullerror ' test_expect_success GPG 'pull signed commit with --verify-signatures' ' - test_when_finished "git checkout initial" && + test_when_finished "git reset --hard && git checkout initial" && git pull --verify-signatures signed >pulloutput && test_i18ngrep "has a good GPG signature" pulloutput ' test_expect_success GPG 'pull commit with bad signature without verification' ' - test_when_finished "git checkout initial" && + test_when_finished "git reset --hard && git checkout initial" && git pull --ff-only bad 2>pullerror ' test_expect_success GPG 'pull commit with bad signature with --no-verify-signatures' ' - test_when_finished "git checkout initial" && + test_when_finished "git reset --hard && git checkout initial" && test_config merge.verifySignatures true && test_config pull.verifySignatures true && git pull --ff-only --no-verify-signatures bad 2>pullerror
-- 2.15.1-558-ged696bbdd8