git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] pull: add config option for verifySignatures

From
Hans Jerry Illikainen <hji@dyntopia.com>
Date
Dec 10, 2017, 06:48 UTC
Message-ID
<20171210064840.GA8087@darpa.mil>
In-Reply-To
<20171209120623.GC6006@alpha.vpn.ikke.info>
On Sat, Dec 09, 2017 at 01:06:23PM +0100, Kevin Daudt wrote:
Show 14 quoted lines
> On Sat, Dec 09, 2017 at 09:05:30AM +0000, Hans Jerry Illikainen wrote:
> > Verify the signature of the tip commit when `pull.verifySignatures` is
> > true.  This option overrides `merge.verifySignatures` on pull, and can
> > be disabled with the option `--no-verify-signatures`.
> 
> Is there a reason why git pull would need a different behaviour from git
> merge? Pull itself is just a convenience command for fetch +
> merge/rebase.
> 
> One precedent for having a separate configuration option for pull
> however is 'pull.ff', so there might be a usecase for it.
> 
> I guess your commit message could use a motivation on why you want to
> set this differently from 'merge.verifySignature'.

Thanks for the review! I wasn't sure whether pull.verifySignatures made sense -- I included it to be consistent with pull.ff/merge.ff, but it's scrapped in v2.

-- 
hji
Previous: Kevin DaudtNext: Kevin Daudt
Message 6 of 15 in “merge: add config option for verifySignatures”
  1. 1/3 merge: add config option for verifySignaturesHans Jerry Illikainen, Dec 9, 2017
  2. 2/3 t: add tests for pull --verify-signaturesHans Jerry Illikainen, Dec 9, 2017
  3. Kevin DaudtDec 9, 2017
  4. 3/3 pull: add config option for verifySignaturesHans Jerry Illikainen, Dec 9, 2017
  5. Kevin DaudtDec 9, 2017
  6. Hans Jerry IllikainenDec 10, 2017
  7. Kevin DaudtDec 9, 2017
  8. Junio C HamanoDec 12, 2017
  9. 1/2 merge: add config option for verifySignaturesHans Jerry Illikainen, Dec 10, 2017
  10. 2/2 t: add tests for pull --verify-signaturesHans Jerry Illikainen, Dec 10, 2017
  11. Junio C HamanoDec 12, 2017
  12. Re* [PATCH v2 2/2] t: add tests for pull --verify-signaturesJunio C Hamano, Dec 15, 2017
  13. Hans Jerry IllikainenDec 16, 2017
  14. Junio C HamanoDec 17, 2017
  15. 3/2 t5573, t7612: clean up after unexpected success of 'pull' and 'merge'Junio C Hamano, Dec 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.