git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re* [PATCH v2 2/2] t: add tests for pull --verify-signatures

From
Hans Jerry Illikainen <hji@dyntopia.com>
Date
Dec 16, 2017, 09:34 UTC
Message-ID
<20171216093440.GB5617@darpa.mil>
In-Reply-To
<xmqqmv2jpyb6.fsf_-_@gitster.mtv.corp.google.com>
On Fri, Dec 15, 2017 at 11:48:29AM -0800, Junio C Hamano wrote:
Show 20 quoted lines
> Here is what I would propose as a follow-up polishing.
> 
> -- >8 --
> Subject: [PATCH 3/2] t5573: clean up after unexpected success of 'pull', too
> 
> The previous step added test_when_finished to tests that run 'git
> pull' with expectation of success, so that the test after them can
> start from a known state even when their 'git pull' invocation
> unexpectedly fails.  However, tests that run 'git pull' expecting
> it not to succeed forgot to protect later tests the same way---if
> they unexpectedly succeed, the test after them would start from an
> unexpected state.
> 
> Reset and checkout the initial commit after all these tests, whether
> they expect their 'git pull' invocations to succeed or fail.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  t/t5573-pull-verify-signatures.sh | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Thanks! t7612-merge-verify-signatures.sh also lacks cleanup for test_must_fail brokenness. Would you prefer test_when_finished to be included in the two patches as a v3?

-- 
hji
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 15 in “merge: add config option for verifySignatures”
  1. 1/3 merge: add config option for verifySignaturesHans Jerry Illikainen, Dec 9, 2017
  2. 2/3 t: add tests for pull --verify-signaturesHans Jerry Illikainen, Dec 9, 2017
  3. Kevin DaudtDec 9, 2017
  4. 3/3 pull: add config option for verifySignaturesHans Jerry Illikainen, Dec 9, 2017
  5. Kevin DaudtDec 9, 2017
  6. Hans Jerry IllikainenDec 10, 2017
  7. Kevin DaudtDec 9, 2017
  8. Junio C HamanoDec 12, 2017
  9. 1/2 merge: add config option for verifySignaturesHans Jerry Illikainen, Dec 10, 2017
  10. 2/2 t: add tests for pull --verify-signaturesHans Jerry Illikainen, Dec 10, 2017
  11. Junio C HamanoDec 12, 2017
  12. Re* [PATCH v2 2/2] t: add tests for pull --verify-signaturesJunio C Hamano, Dec 15, 2017
  13. Hans Jerry IllikainenDec 16, 2017
  14. Junio C HamanoDec 17, 2017
  15. 3/2 t5573, t7612: clean up after unexpected success of 'pull' and 'merge'Junio C Hamano, Dec 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.