Re: [PATCH v3 10/15] rebase: add an --am option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 8, 2020, 17:18 UTC
- Message-ID
- <xmqqmuax3lzv.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <9ac52ef1-c1cb-45aa-178a-ec5a282bd761@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 5 quoted lines
> I view this change in the default backend as similar to the rewrite in > C in that it is an implementation detail we're changing that should be > transparent (and beneficial in terms of performance) to the > user. There we provided a configuration variable but not a command > line option to control if it was used or not.
Do you mean things like GIT_TEST_ADD_I_USE_BUILTIN? I think it is OK to have such an escape mechanism to allow people to opt out of a new reimplementation until it matures, but I do not offhand recall doing so with config.