Re: [PATCH v5 20/20] rebase: rename the two primary rebase backends
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 12, 2020, 19:07 UTC
- Message-ID
- <xmqqk13pfl3m.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CABPp-BHyNvxQZ5q=9WXXESTPmxFe4fAiE5roGeV2H+XJ_cpDmg@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
> I'm a little worried about ignoring the setting and just picking one;
I am more than a little worried, too. I think erroring out is warranted in this case for exactly the reason you gave here.
Show 6 quoted lines
> if the setting has been marked and they set it to e.g. "appply" (one
> too many p's), then does it really make sense to just show a warning
> but continue using the backend they didn't want, especially since they
> may miss the warning among the rest of the output? I'd rather go the
> route of improving the message, perhaps:
> _("Unknown rebase.backend config setting: %s")