git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] read-cache: avoid misaligned reads in index v4

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 26, 2022, 23:02 UTC
Message-ID
<xmqqmtalagdi.fsf@gitster.g>
In-Reply-To
<YzH+IPFBGleIsAUe@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I do find it a bit more straight-forward, but the extra copy is ugly,
> plus the "yuck" comment.

Yeah, the "yuck" memcpy() is, eh, unfortunate. Consistently using a single "pointer" (pos) to keep track of where we are does make the structure of the code appear uniform and easier to follow, though.

Previous: Jeff KingNext: Phillip Wood
Message 8 of 12 in “read-cache: avoid misaligned reads in index v4”
  1. read-cache: avoid misaligned reads in index v4Victoria Dye via GitGitGadget, Sep 23, 2022
  2. Jeff KingSep 23, 2022
  3. Junio C HamanoSep 23, 2022
  4. Victoria DyeSep 26, 2022
  5. Jeff KingSep 26, 2022
  6. Jeff KingSep 26, 2022
  7. Jeff KingSep 26, 2022
  8. Junio C HamanoSep 26, 2022
  9. Phillip WoodSep 25, 2022
  10. Junio C HamanoSep 26, 2022
  11. read-cache: avoid misaligned reads in index v4Victoria Dye via GitGitGadget, Sep 28, 2022
  12. Junio C HamanoSep 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.