git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] read-cache: avoid misaligned reads in index v4

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 28, 2022, 17:34 UTC
Message-ID
<xmqqleq3v1w7.fsf@gitster.g>
In-Reply-To
<pull.1366.v2.git.1664385541084.gitgitgadget@gmail.com>
"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 8 quoted lines
> +	/*
> +	 * NEEDSWORK: using 'offsetof()' is cumbersome and should be replaced
> +	 * with something more akin to 'load_bitmap_entries_v1()'s use of
> +	 * 'read_be16'/'read_be32'. For consistency with the corresponding
> +	 * ondisk entry write function ('copy_cache_entry_to_ondisk()'), this
> +	 * should be done at the same time as removing references to
> +	 * 'ondisk_cache_entry' there.
> +	 */

Sounds sensible. Will replace and merge down to 'next'--- it will most likely be part of the first batch in the next cycle.

Thanks, all.
Previous: Victoria Dye via GitGitGadget
Message 12 of 12 in “read-cache: avoid misaligned reads in index v4”
  1. read-cache: avoid misaligned reads in index v4Victoria Dye via GitGitGadget, Sep 23, 2022
  2. Jeff KingSep 23, 2022
  3. Junio C HamanoSep 23, 2022
  4. Victoria DyeSep 26, 2022
  5. Jeff KingSep 26, 2022
  6. Jeff KingSep 26, 2022
  7. Jeff KingSep 26, 2022
  8. Junio C HamanoSep 26, 2022
  9. Phillip WoodSep 25, 2022
  10. Junio C HamanoSep 26, 2022
  11. read-cache: avoid misaligned reads in index v4Victoria Dye via GitGitGadget, Sep 28, 2022
  12. Junio C HamanoSep 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.