git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH] merge: use reverse_commit_list() for list reversal

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 3, 2023, 19:07 UTC
Message-ID
<xmqqmt5uo9ea.fsf@gitster.g>
In-Reply-To
<CABPp-BHnXy+Hpv4y83znMxDGOTCZQfYhnDon=ehBDGOxAnW1vQ@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 18 quoted lines
> Also, gitgitgadget #1156 was opened because of my suggestion to do
> this as a "leftoverbit", i.e. I was suggesting it as a micro-project
> to new people.  I should have checked at the time that it was a valid
> micro-project, but neglected to do so.  You merely came along and
> started implementing what was suggested.
>
> Anyway, the point of the GSoC microprojects are to make sure you are
> familiar with how to format and submit patches to the mailing list and
> respond; having the code you contribute in a microproject be accepted
> is not required, just a bonus.  And you clearly managed to send the
> patch to the list, had a correctly formatted commit message (short
> summary with area and correct lack of capitalization, good
> descriptions, signed-off-by), got the additional notes for reviewers
> (very helpful!) in the correct spot, etc., so I still see this as a
> successful microproject for you.  I apologize for not doing my due
> diligence when I suggested it, and for us not catching that it should
> have been closed when someone implemented the valid half of the
> suggestion last year.

One possible action item for us may be to rename or give comment to highlight the in-place destructive nature of the function to make it easier for developers to use (or avoid misusing) it.

Previous: Elijah NewrenNext: Kousik Sanagavarapu
Message 8 of 10 in “merge: use reverse_commit_list() for list reversal”
  1. Kousik SanagavarapuFeb 2, 2023
  2. Junio C HamanoFeb 2, 2023
  3. Kousik SanagavarapuFeb 3, 2023
  4. Kousik SanagavarapuFeb 3, 2023
  5. Elijah NewrenFeb 2, 2023
  6. Kousik SanagavarapuFeb 3, 2023
  7. Elijah NewrenFeb 3, 2023
  8. Junio C HamanoFeb 3, 2023
  9. Kousik SanagavarapuFeb 5, 2023
  10. Kousik SanagavarapuFeb 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.