git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH] merge: use reverse_commit_list() for list reversal

From
Kousik Sanagavarapu <five231003@gmail.com>
Date
Feb 5, 2023, 18:12 UTC
Message-ID
<20230205181257.159652-1-five231003@gmail.com>
In-Reply-To
<xmqqmt5uo9ea.fsf@gitster.g>
On Sat, 4 Feb 2023 at 00:37, Junio C Hamano <gitster@pobox.com> wrote:
> One possible action item for us may be to rename or give comment to
> highlight the in-place destructive nature of the function to make it
> easier for developers to use (or avoid misusing) it.

There is a comment describing what the function does in commit.h but it doesn't _explicitly_ warn about this destructive behavior (although, with a little thinking, developers can infer that the function can cause this behavior after reading the comment). So, maybe we should go with the comment being a bit more descriptive?

Thanks
Previous: Junio C HamanoNext: Kousik Sanagavarapu
Message 9 of 10 in “merge: use reverse_commit_list() for list reversal”
  1. Kousik SanagavarapuFeb 2, 2023
  2. Junio C HamanoFeb 2, 2023
  3. Kousik SanagavarapuFeb 3, 2023
  4. Kousik SanagavarapuFeb 3, 2023
  5. Elijah NewrenFeb 2, 2023
  6. Kousik SanagavarapuFeb 3, 2023
  7. Elijah NewrenFeb 3, 2023
  8. Junio C HamanoFeb 3, 2023
  9. Kousik SanagavarapuFeb 5, 2023
  10. Kousik SanagavarapuFeb 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.