git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH] merge: use reverse_commit_list() for list reversal

From
Kousik Sanagavarapu <five231003@gmail.com>
Date
Feb 3, 2023, 17:49 UTC
Message-ID
<20230203174910.123441-1-five231003@gmail.com>
In-Reply-To
<CABPp-BHE=zGT_vPW8+TZn-wqmufhVdGQT-=LXoLQkto6TMrnrA@mail.gmail.com>

Now, I think I understand the mistake that I did. Even if it did work for one merge strategy, the code would not be good as the helper function is not doing what it is intended to do. In any case, I should have been more careful submitting the patch.

On a side note, I think we can now close the issue #1156 on gitgitgadget? As with builtin/merge.c out of the way, the only other case is in revision.c and the use of the helper function there is inapproriate.

Thanks for the explanation.
Previous: Elijah NewrenNext: Elijah Newren
Message 6 of 10 in “merge: use reverse_commit_list() for list reversal”
  1. Kousik SanagavarapuFeb 2, 2023
  2. Junio C HamanoFeb 2, 2023
  3. Kousik SanagavarapuFeb 3, 2023
  4. Kousik SanagavarapuFeb 3, 2023
  5. Elijah NewrenFeb 2, 2023
  6. Kousik SanagavarapuFeb 3, 2023
  7. Elijah NewrenFeb 3, 2023
  8. Junio C HamanoFeb 3, 2023
  9. Kousik SanagavarapuFeb 5, 2023
  10. Kousik SanagavarapuFeb 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.