Re: [PATCH v2 2/2] reftable/block: fix binary search over restart counter

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 11, 2024, 17:33 UTC
Message-ID: <xmqqmsr4smfx.fsf@gitster.g>
In-Reply-To: <Ze6UDkipgNsDVCwf@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

> But we do know to bubble the error up via the pasesd-in args by setting
> `args->error = -1`. Funny thing though: I just now noticed that we check
> for `args.error` _before_ we call `binsearch()`. Oops.
>
> I will send a follow-up patch that addresses these issues.

Thanks, that is doubly amusing ;-)