From: Junio C Hamano Date: Mon, 11 Mar 2024 17:33:22 GMT Subject: Re: [PATCH v2 2/2] reftable/block: fix binary search over restart counter Message-ID: In-Reply-To: Patrick Steinhardt writes: > But we do know to bubble the error up via the pasesd-in args by setting > `args->error = -1`. Funny thing though: I just now noticed that we check > for `args.error` _before_ we call `binsearch()`. Oops. > > I will send a follow-up patch that addresses these issues. Thanks, that is doubly amusing ;-)